Ensure that every command has setFlags and hasWrapper functions #3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mmh many commands are not covered by tests and maybe I forget some functions; I will open other pull requests to raise the coverage. |
|
👍 |
This was referenced Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is a simplified version of #2810 and maybe for some ways better because it prefers composition over inheritance and it is less invasive right now.
There are two commits that ensure that we always have setFlags and hasWrapper functions.
This is the first step to move some responsabilities from the index towards the command classes.
Test plan
For what I see every command is covered, but let me know if I have to cover something.